-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blind): provided ellipsis for blind header #1186
Conversation
🦋 Changeset detectedLatest commit: caba100 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@ridvandmrc Looks like there are some errors in our visual testing environment. You find a html test report on your To get some information about visual testing checkout our short guide: https://github.com/siemens/ix/blob/main/CONTRIBUTING.md#visual-regression-testing |
Hi @danielleroux , |
The <ix-blind
label="Test long long long long long long long 123 456 789"
sublabel="Sub long long long long long 123 456 789"
style={{ width: '40rem' }}
></ix-blind> The label text max with should be half of the blind (text content), following by the sublabel. All labels have to be showing ellipses as text overflow style. If you have access you can checkout the figma specs: https://www.figma.com/file/r2nqdNNXXZtPmWuVjIlM1Q/iX-Components---Brand-Dark?node-id=9598%3A189577 |
Hi @danielleroux , Thanks |
Thank you. As mentioned in the PR template, please add some testcases (visual regression tests) to verify the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Missing visual-regression test cases
@ridvandmrc Please checkout the CONTRIBUTING.md. There is a chapter regarding visual tests. You have to run it inside a container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated margin. Please also delete the "blind-sublabel-" snapshots since they are obsolete.
50189a4
💡 What is the current behavior?
If a long label is used, Ellipsis is not looking .
GitHub Issue Number: #1165
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
yarn docs
)yarn test
)yarn visual-regression
)yarn lint
)yarn build
, changes pushed)👨💻 Help & support